Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration: add test for deploying Nvidia gpu-operator through Helm chart #907

Closed

Conversation

aznashwan
Copy link
Contributor

No description provided.

@aznashwan aznashwan requested a review from a team as a code owner December 16, 2024 18:12
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aznashwan
Did a first pass

tests/integration/tests/test_nvidia_gpu_operator.py Outdated Show resolved Hide resolved
tests/integration/tests/test_nvidia_gpu_operator.py Outdated Show resolved Hide resolved
tests/integration/tests/test_nvidia_gpu_operator.py Outdated Show resolved Hide resolved
tests/integration/tests/test_nvidia_gpu_operator.py Outdated Show resolved Hide resolved
@aznashwan aznashwan force-pushed the nvidia-gpu-operator-integration branch 4 times, most recently from f977335 to af810eb Compare December 18, 2024 17:20
@aznashwan
Copy link
Contributor Author

@bschimke95 the failures on 20.04 and 22.04 all look like flakes which are completely unrelated to the Nvidia test.

On 24.04 where it actually ran to completion without flakes, it looks like the test skipping logic is doing its thing correctly:

https://github.com/canonical/k8s-snap/actions/runs/12398058843/job/34610621883?pr=907#step:9:4243

@aznashwan aznashwan force-pushed the nvidia-gpu-operator-integration branch from af810eb to ff64c3e Compare December 20, 2024 12:44
@aznashwan
Copy link
Contributor Author

Re-running all workflows after random build failure due to launchpad.net internal server error.

@aznashwan
Copy link
Contributor Author

@bschimke95 finally got an unflaky e2e run.

The GPU test properly skipped itself for lack of a GPU; so it looks like it's finally ready to merge.

@aznashwan aznashwan force-pushed the nvidia-gpu-operator-integration branch from ff64c3e to d3ac2f9 Compare January 6, 2025 19:18
@aznashwan
Copy link
Contributor Author

Unfortunately, it just hit me that because I had to remove my Canonical e-mail from my GitHub account, the commits are no longer verified. 😞

Please feel free to amend/cherry-pick these commits as you see fit!

@aznashwan
Copy link
Contributor Author

Superseded by #929, closing now.

@aznashwan aznashwan closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants